Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Change token refresh condition and retry upserts #1215

Merged

Conversation

ivankalinovski
Copy link
Contributor

@ivankalinovski ivankalinovski commented Dec 9, 2024

Description

What -

  1. Update the condition upon which the JWT token is refreshed so it will refresh on expiration instead of only after.
  2. Set upsert entenies as retryable.
  3. Remove timeout in favor of global timeout.
  4. Update handle_request to use method for identifying retryable requests.

Why -
User receives 401 errors because JWT is expired so entities are not inserted.

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

1. Update the condition upon which the JWT token is refreshed so it will refresh on expiration instead of only after.
2. Set upsert entenies as retryable.
3. Remove timeout in favor of global timeout.
4. Update `handle_request` to use method for indentifying retryable requests.
@ivankalinovski ivankalinovski requested a review from a team as a code owner December 9, 2024 16:31
CHANGELOG.md Outdated
Comment on lines 15 to 17
- Remove timeout in favor of global timeout. (Change token refresh condition and retry upserts)
- Update `handle_request` to use method for indentifying retryable requests. (Change token refresh condition and retry upserts)
- Set upsert entenies as retryable. (Change token refresh condition and retry upserts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove (Change token refresh condition and retry upserts)

CHANGELOG.md Outdated

### Bug Fixes

- Remove timeout in favor of global timeout. (Change token refresh condition and retry upserts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove specific timeout for search request in favor of global timeout

@ivankalinovski ivankalinovski force-pushed the PORT-11857-bug-dd-integration-does-not-refresh-token branch from acffc38 to 04b4bbd Compare December 9, 2024 16:51
@github-actions github-actions bot added size/S and removed size/XS labels Dec 9, 2024

- Remove specific timeout for search request in favor of global timeout.
- Update `handle_request` to use method for indentifying retryable requests.
- Set upsert entenies as retryable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Set upsert entenies as retryable.
- Set upsert entities as retryable.

@ivankalinovski ivankalinovski merged commit bb37e13 into main Dec 9, 2024
18 checks passed
@ivankalinovski ivankalinovski deleted the PORT-11857-bug-dd-integration-does-not-refresh-token branch December 9, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants